Fixup Blob and File APIs #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
armanbilge reviewed Aug 21, 2022
There was a problem hiding this comment.
Ok ... so looks like this one is going to be a bit of a rabbit hole 😅
The official specification is here:
https://www.w3.org/TR/FileAPI/#dfn-file
There it defines options as a FilePropertyBag which extends a BlobPropertyBag.
It also defines a BlobPart for the fileBits.
armanbilge reviewed Aug 21, 2022
Closed
armanbilge reviewed Aug 21, 2022
armanbilge reviewed Aug 22, 2022
zetashift force-pushed the fix/file-api#601 branch from 791dfcf to 335d828 Compare 
| I think I did an oopsie with Git edit: hopefully a squash can suffice :P |
armanbilge reviewed Aug 22, 2022
armanbilge reviewed Aug 22, 2022
armanbilge approved these changes Aug 22, 2022
| Anytime! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I'm unsure about a lot of things about the code I wrote, for example moving the
nameto the constructor part. And shouldFileOptionsbe in it's separate file? Also unsure about the type ofbits.Anyhow let me know what you think then I'll gladly change it.