Skip to content

Conversation

987Nabil
Copy link
Contributor

setCustomValiditys error message is shown only when reportValidity
is called afterwards.
See https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/setCustomValidity
for example.

@armanbilge
Copy link
Member

armanbilge commented Apr 26, 2022

Thanks for your contribution! :) Would you mind adding a scaladoc by copy-pasting the descriptions on the MDN page?

https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/reportValidity
https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/reportValidity

`setCustomValidity`s error message is shown only when `reportValidity` is called afterwards. See https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/setCustomValidity for example.
@987Nabil 987Nabil force-pushed the add-report-validity branch from edb7a13 to 01cb9ff Compare April 27, 2022 07:39
@987Nabil
Copy link
Contributor Author

Done @armanbilge 😃

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for all your work, much appreciated! :)

@armanbilge armanbilge merged commit 06adf67 into scala-js:main Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants