Skip to content

Fix #384: Make locales optional in DateTimeFormat & NumberFormat. #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Fix #384: Make locales optional in DateTimeFormat & NumberFormat. #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/scala/org/scalajs/dom/experimental/intl/Intl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ class Collator(locales: js.UndefOr[String | js.Array[String]] = js.undefined,
*/
@js.native
@JSGlobal("Intl.DateTimeFormat")
class DateTimeFormat(locales: String | js.Array[String],
class DateTimeFormat(
locales: js.UndefOr[String | js.Array[String]] = js.undefined,
options: js.UndefOr[DateTimeFormatOptions] = js.undefined)
extends js.Object {
def format(date: js.Date): String = js.native
Expand All @@ -52,8 +53,9 @@ class DateTimeFormat(locales: String | js.Array[String],
*/
@js.native
@JSGlobal("Intl.NumberFormat")
class NumberFormat(locales: String | js.Array[String],
options: js.UndefOr[NumberFormatOptions])
class NumberFormat(
locales: js.UndefOr[String | js.Array[String]] = js.undefined,
options: js.UndefOr[NumberFormatOptions] = js.undefined)
extends js.Object {
def format(number: Double): String = js.native
def resolvedOptions(): NumberFormatOptions = js.native
Expand Down