Skip to content

Conversation

@japgolly
Copy link
Contributor

No description provided.

@sjrd
Copy link
Member

sjrd commented Aug 26, 2015

What spec did you use? I see http://www.w3.org/html/wg/drafts/html/master/editing.html#the-datatransfer-interface and there are discrepancies.

@sjrd
Copy link
Member

sjrd commented Aug 27, 2015

Hum ... is there some evidence that addElement is supported by other browsers? Is this a Firefox-only thing? Why would it appear in MDN but not in the spec? Wand why, why doesn't MDN reference the spec it bases itself on, as it usually does?

Regardless, I would stick to format instead of type for the parameter names. Since there two contradicting names, let's keep the Scala-friendly one ;)

@japgolly
Copy link
Contributor Author

Woah, so in 2011 they dropped it from the spec (http://lists.w3.org/Archives/Public/public-webapps/2011OctDec/0171.html) but for some reason MDN/Firefox has kept it around.

Ok I've removed it changed type back to format as requested. Should be good now.

@sjrd
Copy link
Member

sjrd commented Aug 27, 2015

LGTM, thanks.

sjrd added a commit that referenced this pull request Aug 27, 2015
Add new and correct existing fns in DataTransfer
@sjrd sjrd merged commit e6a2c82 into scala-js:master Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants