Issue 16 - Add scalacheck datetime #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @@ -0,0 +1,53 @@ | |||
| package scalachecklib | |||
There was a problem hiding this comment.
Let's create an issue to remove this once the scala-exercises core library is upgraded.
There was a problem hiding this comment.
Sure, I will do it once we merge this
| The scalacheck-datetime section looks great to me. If you had any feedback about getting that working I'd love to hear it. Cheers! |
| Nice!, are you referring to getting that working locally or on production? To deploy on production we need to publish the artifact in maven and redeploy the scala-exercises web app. @juanpedromoreno and I can take care of that. If you need help getting that working locally, just ping me through slack. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR resolves #16
It adds the follow changes:
scalacheckandscalatestversionsscalatest3.0.xscalacheck-datetimesectionPlease @juanpedromoreno could you take a look? Especially to the 1 and 2 points.
@noelmarkham please, could you review the
scalacheck-datetimesection? Thanks