- Notifications
You must be signed in to change notification settings - Fork 16
Closed
Description
As discussed, my comments from these exercises. I think they're really good.
Properties
- The
sqrt
function returnsDouble
, notInt
, even though (for example)9.0 == 9
. But the property provided does not work for negative numbers. While I understand this is only an example, and thus it doesn't matter if the property holds or not, I would suggest it would be clearer if the property holds, and is unambiguous. - I think the explanation of implication could be better.
- The implication example (
(n == 0) ==> (n == 0)
) is a bit confusing. I think it would be better if the implication was different to the property. - In Combining Properties, have both
forAll
s at the same indent level, as I thought these were nested. - I think the Grouping Properties section is confusing because the
ZeroSpecification
class takes a parameter, which (I think) is only ever0
. I think it would just be clearer if thevalue
parameter is removed and simply replaced with0
.
Generators
- Be consistent with
{
and(
on thecheck
methods.
I can't think of any headline items to add, perhaps you may want to show a property that actually fails, and perhaps how to label properties and generators.
I've not done a language review on this either, please let me know if you want me to do that.
I'll leave these suggestions to you, but I'm happy to help if you need it.
Metadata
Metadata
Assignees
Labels
No labels