Skip to content

Conversation

@TiagoRibeiro25
Copy link
Contributor

@TiagoRibeiro25 TiagoRibeiro25 commented Sep 15, 2024

Added functionality to allow users to define custom keybindings.

This update introduces a new "keybindings" section in the configuration file, which contains the default keybindings for the application. Users can now modify these keybindings to suit their preferences. This enhancement addresses the issue reported in #135.

Copy link
Owner

@savedra1 savedra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TiagoRibeiro25 thank you so much for this! It's super appreciated 💙 I have tested this locally and it works well. My notes are only for minor things, let me know what you think 😄

@TiagoRibeiro25
Copy link
Contributor Author

I forgot to change back to the defaults after I did some testing, sorry for that silly mistake 😋

About the fuzzySelect, I didn't look into it, but it was in the original code.

@savedra1
Copy link
Owner

I forgot to change back to the defaults after I did some testing, sorry for that silly mistake 😋

About the fuzzySelect, I didn't look into it, but it was in the original code.

No worries!

I think fuzzySelect is my bad.. not actually being used by anything. It can be dropped entirely from the keys.go file and from the new struct 😄

@savedra1
Copy link
Owner

savedra1 commented Sep 15, 2024

Another thought @TiagoRibeiro25, do you think it would also be a good idea to apply the custom keybinds to the secondary view screens? E.g the delete pinned confirmation screen/preview screen. All could be handled from the same keys.go file.

Secondary views now use the keybindings specified in the config file
@TiagoRibeiro25
Copy link
Contributor Author

@savedra1 I overlooked the secondary views initially, but I've now added support for them. I had to adjust some keybindings to better suit the new setup. Another solution would be adding more specific keybindings to the config file just for those screens.

Copy link
Owner

@savedra1 savedra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@savedra1
Copy link
Owner

Closes #135

@savedra1 savedra1 merged commit 3cb02c6 into savedra1:main Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants