This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Fix sideline zk configuration #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Should we be compiling the list of changes in the CHANGELOG as part of these PRs? |
Crim approved these changes Jan 4, 2019
stanlemon force-pushed the lemon/sideline-zk-root branch from e594f90 to ca7dbaa Compare 
stanlemon commented Jan 4, 2019
| */ | ||
| @BeforeEach | ||
| void resetMockConsumerPartitions() { | ||
| MockConsumer.partitions = Arrays.asList(1); |
Contributor Author
There was a problem hiding this comment.
@Crim this ended up being my flapper problem. Some day I'll revisit the MockConsumer entirely and fix this in a better way. You called it though. 😉
stanlemon commented Jan 4, 2019
| return new SidelineRequestIdentifier(identifier.toString()); | ||
| } | ||
| | ||
| private String generateIdFromJson(final String dataJson) throws NoSuchAlgorithmException { |
Contributor Author
There was a problem hiding this comment.
Functionally the same as what was there before, just no longer dependent upon javax.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The 'root' configuration only supports one root, this typo is a holdover from the old implementation where we supported a list of roots to watch.