This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Make the API calls compatible with Stanza mainline #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for the contribution! Before we can merge this, we need @reachsumit to sign the Salesforce.com Contributor License Agreement. |
Collaborator
| Unfortunately I think we'll have to forgo this change since the Stanza package was co-opted to be the new CoreNLP python library. Also tokenization changed and therefore will be incompatible with previous results. I will add a note to the README about this. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
CoreNLPClientimport and the annotation response structure used in the current code does not work with Stanza API. This commit makes the annotation code compatible with Stanza mainline.