[wc] faster character count #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Nice. tiny comment: No need to pass global variable table as a function parameter. Will review and test in depth tomorrow. |
Contributor
| Does this work if a multi-byte character straddles the edge of two input buffers? |
Contributor Author
| Well I just tested with a 200Mb file filled with these 2 chars 生履, with no space and I get the same result as GNU wc -m, wc2 -m and wz -c. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
On my machine, time decreased by 75% on 1Gb utf8.txt, from 7.4s to 1.85s.