Skip to content

Port ls to ftw #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgarzik merged 1 commit into from
Sep 26, 2024
Merged

Port ls to ftw #231

jgarzik merged 1 commit into from
Sep 26, 2024

Conversation

@JRF63
Copy link
Contributor

@JRF63 JRF63 commented Sep 21, 2024 •
edited
Loading

Had to modify ftw quite a bit to accommodate the required directory listing order for ls. This PR modified more files than necessary because of the need to add new options to ftw::traverse_directory - I used the struct update syntax to hopefully avoid needing to do it again in the future if more options are added:

 ftw::TraverseDirectoryOpts { list_contents_first: true, ..Default::default() // Sets the other options to their default values },

Also fixed clippy errors on the modified files while I was at it.
@JRF63 JRF63 marked this pull request as draft September 21, 2024 14:04
@JRF63 JRF63 marked this pull request as ready for review September 26, 2024 13:03
@jgarzik jgarzik merged commit 0424b24 into rustcoreutils:main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@JRF63 @jgarzik