Add PhysicalAddress and VirtualAddress type aliases #518
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These correspond to
EFI_PHYSICAL_ADDRESSandEFI_VIRTUAL_ADDRESS. These usually end up being converted to a pointer type, but notably they are always 64-bit regardless of the target platform. This change revealed a bug in theAllocateTypeenum; it was usingusizefor a couple members, but that is not correct for all targets, e.g.i686-unknown-uefi.Checklist
Rewriting History guide for
help.