Fix potential UB in file info #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When running the file info tests under Miri with `-Zmiri-tag-raw-pointers` enabled, `new_impl` triggered a Stacked Borrows error. This occurred because after a mutable info pointer to the raw `u8` buffer was created, we went back and created another mutable pointer within the `u8` buffer to copy the name string into. Fix by creating the name destination pointer from the info pointer rather than the `u8` buffer pointer.
| (I'd like to enable |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When running the file info tests under Miri with
-Zmiri-tag-raw-pointersenabled,new_impltriggered a StackedBorrows error. This occurred because after a mutable info pointer to the
raw
u8buffer was created, we went back and created another mutablepointer within the
u8buffer to copy the name string into.Fix by creating the name destination pointer from the info pointer
rather than the
u8buffer pointer.