Make Error public #382
Merged
Make Error public #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
josephlr approved these changes Mar 5, 2022
src/result/error.rs Outdated
| self.status | ||
| } | ||
| | ||
| /// Get error payload. |
Contributor
There was a problem hiding this comment.
I'm not sure if the terminology used elsewhere is "payload" or "error data". Either works, but we should be consistent.
Member Author
There was a problem hiding this comment.
Only one other use of payload in this file, so switched both to data.
As mentioned in rust-osdev#360 (comment), it seems like an oversight that this type isn't part of the public API. Added docstrings to the public methods.
nicholasbishop force-pushed the bishop-err-pub branch from d071ff1 to 15593a4 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As mentioned in #360 (comment), it seems like an oversight that this type isn't part of the public API.
Added docstrings to the public methods.