Don't run doctests with invalid pointers #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `Handle::from_ptr` and `SystemTable<View>::from_ptr` doctests use a `0xdeadbeef` pointer, which of course is not valid. Change the tests to compile but not actually run so that they don't trigger UB. Noticed this when running the unit tests with Miri, which caught the undefined behavior the in the SystemTable case.
| Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
Handle::from_ptrandSystemTable<View>::from_ptrdoctests use a0xdeadbeefpointer, which of course is not valid. Change the tests tocompile but not actually run so that they don't trigger UB.
Noticed this when running the unit tests with Miri, which caught the
undefined behavior the in the SystemTable case.