Add ia32 target to xtask and test in CI #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This corresponds to the `i686-unknown-uefi` rust triple. The test runner seems to work fine without any changes, so remove the note in the readme saying the crate has only been tested on 64-bit.
nicholasbishop force-pushed the bishop-test-x86-3 branch from 8bbc689 to a849c14 Compare 
GabrielMajeri approved these changes Feb 7, 2022
Collaborator
GabrielMajeri left a comment
GabrielMajeri left a comment There was a problem hiding this comment.
Changes look good, thanks!
Collaborator
| I've also added this job as one of the required checks before merging new PRs into |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.