uefi: use core::net types in public API, remove net type duplicates #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
phip1611 changed the title core::net types where possible, remove duplicated types phip1611 force-pushed the core-net branch 4 times, most recently from 728dc3b to 6291e95 Compare 
| I personally see this as a major step forward. On the other hand, I'm biased 😁 I'm looking forward to the discussion and other's ideas! |
phip1611 force-pushed the core-net branch 2 times, most recently from c39462e to 17109fc Compare phip1611 force-pushed the core-net branch 2 times, most recently from f36c480 to 86aa5ce Compare 
phip1611 changed the title core::net types where possible, remove duplicated typescore::net types where possible, remove duplicated types 4 tasks
phip1611 force-pushed the core-net branch 2 times, most recently from 2b7510a to a836560 Compare phip1611 changed the title core::net types where possible, remove duplicated typescore::net types in public API, remove net type duplicates, use uefi-raw's net types 
This does not use core::net::IpAddr in all possible public interfaces. Although there is opportunity for that, this commit only makes `uefi` compatible with the new `uefi-raw` type.
phip1611 changed the title core::net types in public API, remove net type duplicates, use uefi-raw's net typescore::net types in public API, remove net type duplicates | Closing in favor of a new one. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR started as a "big PR" to address the vision in #1575. In the meantime, multiple smaller PRs have been spitted out and merged before. This is the final PR to close the ticket.
TL;DR:
uefiuefi-raw's net typesCloses #1575.
Steps to Undraft
Checklist