UEFI Allocator: add PAGE_SIZE shortcut #1611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
phip1611 force-pushed the globalalloc branch 2 times, most recently from c3e3819 to b8edf4c Compare 
| General note: there are a lot of changes going on in this PR. I know it's broken down more clearly by commit, but especially when I'm just "allocating" (😉) 5 or 10 minutes of review time to a PR it helps to have less stuff in each one. E.g. the implementation of |
2 tasks
phip1611 changed the title allocator_apicores allocator_api: add PAGE_SIZE shortcut phip1611 changed the title cores allocator_api: add PAGE_SIZE shortcut 
This prepares changes in upcoming commits.
This is a prerequisite for the next commit.
Allocating page-aligned memory via the global allocator is not uncommon for UEFI OS loaders. Therefore, it is feasible to use a shortcut in the allocator, and directly use boot::allocate_pages() rather than boot::allocate_pool(). We can look at the TRACE messages of `cargo xtask run` to verify that the shortcut is taken.
nicholasbishop approved these changes Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Please review this commit-by-commit.
Checklist