Upstream two changes from Pebble's fork #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GabrielMajeri approved these changes Aug 7, 2020
Collaborator
| To get CI green:
|
Member Author
| Thanks @GabrielMajeri, CI is now green |
Collaborator
| Thank you for the contribution! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This upstreams two local changes from Pebble's fork of
uefi-rs, which would allow us to use the official release:LoadedImage::load_optionswhere a slice is created from a null pointer if no load options are passed, causing a panic. Fixed by returning an empty string if there aren't any load options. Also documents this behaviour.MemoryTypes, checking that it's valid.