Add variable key functions to uefi::runtime #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This will allow it to be used in the new runtime module with freestanding functions.
The interface is slightly different than in `uefi/src/table/runtime.rs`, where we just have a function to get all keys at once in a `Vec<VariableKey>`. For the new implementation, two interfaces are provided: `get_next_variable_key` is a low-level interface that does not require the `alloc` feature; it's a simple wrapper around `GetNextVariableName`. `variable_keys` is a high-level interface that returns an iterator. (Following the conventions of Rust's std lib, the iterator type is named `VariableKeys`.) This requires `alloc`.
nicholasbishop force-pushed the bishop-runtime-mod-varkeys-2 branch from aca59e9 to bea0fd9 Compare 
phip1611 reviewed Jul 21, 2024
| // list as the `RuntimeServices::variable_keys` function. | ||
| assert_eq!( | ||
| runtime::variable_keys() | ||
| .map(|k| k.unwrap()) |
There was a problem hiding this comment.
nit: could also be filter_map(core::ops::identity) I think
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The interface is slightly different than in
uefi/src/table/runtime.rs, where we just have a function to get all keys at once in aVec<VariableKey>.For the new implementation, two interfaces are provided:
get_next_variable_keyis a low-level interface that does not require theallocfeature; it's a simple wrapper aroundGetNextVariableName.variable_keysis a high-level interface that returns an iterator. (Following the conventions of Rust's std lib, the iterator type is namedVariableKeys.) This requiresalloc.Also:
VariableKey(needed eq for the tests)Checklist