Clean up duplicate global system table pointer in uefi::helpers #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nicholasbishop force-pushed the bishop-clean-up-globals branch 2 times, most recently from 29f2620 to e2b348e Compare 
These functions now return an `Option`.
Now that `uefi::table` has a pointer to the system table, drop the pointer from `uefi::helpers`.
This functionality is available with `table::system_table_boot` now.
nicholasbishop force-pushed the bishop-clean-up-globals branch from e2b348e to 1970c81 Compare 
phip1611 approved these changes Jun 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Now that
uefi::tablehas a pointer to the system table, drop the pointer fromuefi::helpersand deprecatehelpers::system_table.Note this also includes the change from #1175 to make
system_table_boot/system_table_runtimereturnOptioninstead of panicking.Checklist