Replace cstr8! with a declarative macro #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Implement cstr8 as a proc macro, similar to cstr16.
This is replaced by a new `cstr8` declarative macro in the `uefi` crate.
nicholasbishop force-pushed the bishop-rework-str-macros branch from 371f7b7 to 7b1fa84 Compare 
phip1611 approved these changes Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The implementation is similar to
cstr16, except that since we don't have the equivalent of theucs2crate for latin-1, the internals are implemented directly in this crate.Checklist