Skip to content

Conversation

tnishinaga
Copy link

Recent tests are failing because after nightly-2019-10-05 toolchain couldn't install clippy.
This commit fix it.

References:

Recent tests are failing because after nightly-2019-10-05 toolchain couldn't install clippy. This commit fix it. References: - Failed test - https://travis-ci.org/rust-osdev/uefi-rs/builds/589883701 - status of rustup components - https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu.html
@GabrielMajeri
Copy link
Collaborator

Hello, thanks for your PR, but sadly this will not fix the issue. The part after || with cargo install --git https://github.com/rust-lang/rust-clippy/ is meant to use the latest clippy from Git, since that should compile with the latest nightly.

The reason why CI fails currently is because of QEMU not returning a successful exit code, but I've been unable to reproduce the same error locally.

@tnishinaga
Copy link
Author

Sorry, I misunderstanding currently CI fails reason.

This problem fixed, but rustfmt couldn't build at Build #579.

QEMU not returning a successful exit code

I also recognized this issue and I researching it.

I will create new PR when I fix these problem.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants