Update to libm 0.2.0 #144
Merged
Update to libm 0.2.0 #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
libm 0.2.0 was just released with a bunch of bugfixes. Since none of the public API of libm is exposed, this should be a non-breaking change. Unfortunately they removed the extension traits, so this implementation isn't quite as neat anymore as before.
cuviper reviewed Nov 21, 2019
Instead of tt-munching, we now have a normal trait impl and just use the macros to implement the common methods.
| Thanks -- I went ahead and bumped the version for release. bors r+ |
bors bot added a commit that referenced this pull request Nov 22, 2019
144: Update to libm 0.2.0 r=cuviper a=CryZe libm 0.2.0 was just released with a bunch of bugfixes. Since none of the public API of libm is exposed, this should be a non-breaking change. Unfortunately they removed the extension traits, so this implementation isn't quite as neat anymore as before. Co-authored-by: Christopher Serr <christopher.serr@gmail.com> Co-authored-by: Josh Stone <cuviper@gmail.com>
Build succeeded |
bors bot added a commit to blckngm/titun that referenced this pull request Nov 25, 2019
68: Bump num-traits from 0.2.9 to 0.2.10 r=sopium a=dependabot-preview[bot] Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.9 to 0.2.10. <details> <summary>Changelog</summary> *Sourced from [num-traits's changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md).* > # Release 0.2.10 (2019-11-22) > > - [Updated the `libm` dependency to 0.2][144]. > > **Contributors**: [@​CryZe](https://github.com/CryZe) > > [144]: [rust-num/num-traits#144](https://github-redirect.dependabot.com/rust-num/num-traits/pull/144) </details> <details> <summary>Commits</summary> - [`d9d2357`](rust-num/num-traits@d9d2357) Merge [#144](https://github-redirect.dependabot.com/rust-num/num-traits/issues/144) - [`955e3f8`](rust-num/num-traits@955e3f8) Release 0.2.10 - [`cf68e2a`](rust-num/num-traits@cf68e2a) Invert the float_impl_libm macro - [`9b021ad`](rust-num/num-traits@9b021ad) Update to libm 0.2.0 - See full diff in [compare view](rust-num/num-traits@num-traits-0.2.9...num-traits-0.2.10) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.9&new-version=0.2.10) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
ghost pushed a commit to tommilligan/multiplicative-persistence that referenced this pull request Nov 25, 2019
28: Bump num-traits from 0.2.9 to 0.2.10 r=tommilligan a=dependabot-preview[bot] Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.9 to 0.2.10. <details> <summary>Changelog</summary> *Sourced from [num-traits's changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md).* > # Release 0.2.10 (2019-11-22) > > - [Updated the `libm` dependency to 0.2][144]. > > **Contributors**: [@​CryZe](https://github.com/CryZe) > > [144]: [rust-num/num-traits#144](https://github-redirect.dependabot.com/rust-num/num-traits/pull/144) </details> <details> <summary>Commits</summary> - [`d9d2357`](rust-num/num-traits@d9d2357) Merge [#144](https://github-redirect.dependabot.com/rust-num/num-traits/issues/144) - [`955e3f8`](rust-num/num-traits@955e3f8) Release 0.2.10 - [`cf68e2a`](rust-num/num-traits@cf68e2a) Invert the float_impl_libm macro - [`9b021ad`](rust-num/num-traits@9b021ad) Update to libm 0.2.0 - See full diff in [compare view](rust-num/num-traits@num-traits-0.2.9...num-traits-0.2.10) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.9&new-version=0.2.10) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
cuviper added a commit to cuviper/alga that referenced this pull request Jan 15, 2020
Unfortunately, `libm 0.2` remove the `F32Ext` and `F64Ext` extension traits, which makes it harder to choose the different methods. However, this was already dealt with in rust-num/num-traits#144 for `Float`, so we can piggy-back on that here, no longer using `libm` directly.
cuviper added a commit to cuviper/alga that referenced this pull request Jan 15, 2020
Unfortunately, `libm 0.2` removed the `F32Ext` and `F64Ext` extension traits, which makes it harder to choose the different methods. However, this was already dealt with in rust-num/num-traits#144 for `Float`, so we can piggy-back on that here, no longer using `libm` directly.
sebcrozet pushed a commit to dimforge/alga that referenced this pull request Jan 15, 2020
Unfortunately, `libm 0.2` removed the `F32Ext` and `F64Ext` extension traits, which makes it harder to choose the different methods. However, this was already dealt with in rust-num/num-traits#144 for `Float`, so we can piggy-back on that here, no longer using `libm` directly.
sebcrozet pushed a commit to dimforge/alga that referenced this pull request Mar 2, 2020
Unfortunately, `libm 0.2` removed the `F32Ext` and `F64Ext` extension traits, which makes it harder to choose the different methods. However, this was already dealt with in rust-num/num-traits#144 for `Float`, so we can piggy-back on that here, no longer using `libm` directly.
eclipseo pushed a commit to eclipseo/packed_simd that referenced this pull request Sep 17, 2021
Unfortunately, `libm 0.2` remove the `F32Ext` and `F64Ext` extension traits, which makes it harder to choose the different methods. However, this was already dealt with in rust-num/num-traits#144 for `Float`, so we can piggy-back on that here, no longer using `libm` directly. Close: rust-lang#294
xmas7 pushed a commit to RubyOnWorld/alga that referenced this pull request Sep 6, 2022
Unfortunately, `libm 0.2` removed the `F32Ext` and `F64Ext` extension traits, which makes it harder to choose the different methods. However, this was already dealt with in rust-num/num-traits#144 for `Float`, so we can piggy-back on that here, no longer using `libm` directly.
workingjubilee pushed a commit to rust-lang/packed_simd that referenced this pull request Jul 27, 2023
Unfortunately, `libm 0.2` remove the `F32Ext` and `F64Ext` extension traits, which makes it harder to choose the different methods. However, this was already dealt with in rust-num/num-traits#144 for `Float`, so we can piggy-back on that here, no longer using `libm` directly. Closes rust-lang/packed-simd#294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
libm 0.2.0 was just released with a bunch of bugfixes. Since none of the public API of libm is exposed, this should be a non-breaking change. Unfortunately they removed the extension traits, so this implementation isn't quite as neat anymore as before.