Add a feature to turn on/off blas backend #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ndarray by default turns off blas backend, but ndarray-linalg turns it on by default and there is no way to turn it off. This change adds a cargo feature to control it. It's a default feature, so users who don't want to use blas backend need `default-features = false` in their Cargo.toml.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #385 +/- ## ========================================== + Coverage 86.85% 86.88% +0.02% ========================================== Files 64 64 Lines 3584 3584 ========================================== + Hits 3113 3114 +1 + Misses 471 470 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ndarray by default turns off blas backend, but ndarray-linalg turns it on by default and there is no way to turn it off. This change adds a cargo feature to control it. It's a default feature, so users who don't want to use blas backend need
default-features = falsein their Cargo.toml.This change allows us to use this crate on WebAssembly.