Skip to content

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Sep 24, 2022

Same approach in #333 and #340

  • Merge Eigh_ trait into Lapack trait
  • Create new submodule eigh_generalized for generalized eigenvalue problem for symmetric/hermite matrices
  • Add EighWork and EighGeneralizedWork
@termoshtt termoshtt self-assigned this Sep 24, 2022
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Merging #341 (bef1083) into master (33e2dc3) will decrease coverage by 0.78%.
The diff coverage is 68.87%.

@@ Coverage Diff @@ ## master #341 +/- ## ========================================== - Coverage 90.15% 89.37% -0.79%  ========================================== Files 73 74 +1 Lines 4105 4217 +112 ========================================== + Hits 3701 3769 +68  - Misses 404 448 +44 
Impacted Files Coverage Δ
lax/src/eigh_generalized.rs 47.05% <47.05%> (ø)
lax/src/eigh.rs 97.53% <96.66%> (+2.53%) ⬆️
lax/src/lib.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@termoshtt termoshtt force-pushed the lax-eigh-generalized-work branch from 433db1a to 5d07538 Compare September 25, 2022 09:08
@termoshtt termoshtt added the breaking change Non-compatible change label Sep 25, 2022
@termoshtt termoshtt changed the title Strict memory management for symmetric/Hermite eigenvalue problems Merge Eigh_ into Lapack trait, add strict memory management API Sep 25, 2022
@termoshtt termoshtt changed the title Merge Eigh_ into Lapack trait, add strict memory management API Merge Eigh_ into Lapack trait, add working memory management Sep 25, 2022
@termoshtt termoshtt force-pushed the lax-eigh-generalized-work branch from 632bd71 to bef1083 Compare September 25, 2022 09:56
@termoshtt termoshtt marked this pull request as ready for review September 25, 2022 10:21
@termoshtt termoshtt merged commit f672b07 into master Sep 25, 2022
@termoshtt termoshtt deleted the lax-eigh-generalized-work branch September 25, 2022 10:21
@termoshtt termoshtt added new feature and removed breaking change Non-compatible change labels Oct 3, 2022
@termoshtt termoshtt changed the title Merge Eigh_ into Lapack trait, add working memory management Add lax::eigh::EighWork, merge lax::Eigh_ into Lapack trait Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant