Use lapack-sys crate directly from lax crate #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #328 +/- ## ========================================== + Coverage 89.90% 90.06% +0.15% ========================================== Files 71 71 Lines 3756 3864 +108 ========================================== + Hits 3377 3480 +103 - Misses 379 384 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
termoshtt force-pushed the use-lapack-sys-directly branch from e890abf to 328abd3 Compare termoshtt changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
First step of #327.
The problem of
lapackcrate is it requires slice&[T]which must be initialized while the pointer-based API inlapack-sysdoes not.