Fix Solve::solve_h_* for complex inputs with standard layout #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jturner314 changed the title jturner314 force-pushed the fix-solve_h-complex branch from 7f2b725 to c698704 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #296 +/- ## ========================================== + Coverage 89.01% 89.79% +0.78% ========================================== Files 71 71 Lines 3578 3607 +29 ========================================== + Hits 3185 3239 +54 + Misses 393 368 -25
Continue to review full report at Codecov.
|
jturner314 force-pushed the fix-solve_h-complex branch from c698704 to ffe65cb Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds more tests for the
Solvetrait and fixes the implementation ofsolve_h_*for complex inputs with standard layout.