Skip to content

Disambiguate wording on array size/stride #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2023
Merged

Disambiguate wording on array size/stride #389

merged 1 commit into from
Jan 29, 2023

Conversation

@overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 28, 2023 •
edited
Loading

In the current text:

struct A(u16, u8);

A has an alignment and a size of 4

I read this as saying:

  • A has an alignment of 4 and
  • A has a size of 4

This is not correct. struct A(u16, u8) has an alignment of 2.

Perhaps it was really saying:

  • A has a specified alignment (which we don't state the value of here) and
  • A has a size of 4

This is correct, but a bit confusing.

This proposed change makes the wording less ambiguous.
@RalfJung
Copy link
Member

RalfJung commented Jan 29, 2023

Good catch, thanks!
@RalfJung RalfJung merged commit 9f18694 into rust-lang:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@overlookmotel @RalfJung @digama0