add --check flag to cargo fmt #3890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
topecongiro approved these changes Oct 26, 2019
| let strategy = CargoFmtStrategy::from_opts(&opts); | ||
| let mut rustfmt_args = opts.rustfmt_options; | ||
| if opts.check { | ||
| let check_flag = String::from("--check"); |
There was a problem hiding this comment.
Nit: we can defer the allocation of a String until we absolutely need it:
let check_flag = "--check"; if !rustfmt_args.contains(check_flag) { rustfmt_args.push(check_flag.to_owned()); }There was a problem hiding this comment.
Unfortunately I believe the limitations with Vec::contains that we ran into in #3752 (comment) still exist which prevent using a literal as an arg.
On a related note, I was going to volunteer to work on #3587 and while working on that I'll also look into consolidating the way cargo fmt is transforming/passing flags (like --message-format --> --emit, --check, etc.) to rustfmt which I think may help remove some of these Vec::contains
There was a problem hiding this comment.
Oh my god, I am so dumb 😩 Sorry about that!
calebcartwright force-pushed the cargo-fmt-check branch from 703fa71 to 0a9ec7e Compare 
calebcartwright added a commit to calebcartwright/rustfmt that referenced this pull request Sep 17, 2021
calebcartwright added a commit that referenced this pull request Sep 17, 2021
| backported in #4993 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #3888