Don't suggest explicitly cfg-gating trace! calls in bootstrap #2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was trying to learn more about bootstrap, read about the tracing macros, thought they were cool, but also writing
#[cfg(tracing)] trace!each time gets annoying.So I thought I'd PR a shim macro that hides the
cfginternally (and contribute to rustc finally), but turns out @jieyouxu has already done that in rust-lang/rust#136392Well, guess I'll be content with just a doc change for now then 🙃