Skip to content

Improve the "Diagnostic items" chapter #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 13, 2022
Merged

Improve the "Diagnostic items" chapter #1427

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7f2dc23
found it in alloc too
tshepang Aug 12, 2022
8696894
fix anchor link
tshepang Aug 12, 2022
b2e6a28
missing commas
tshepang Aug 12, 2022
68d3ab4
date-check: diagnostic-items
tshepang Aug 12, 2022
ede6391
style
tshepang Aug 12, 2022
f3ee867
room to breath
tshepang Aug 12, 2022
8ed30f8
more simple
tshepang Aug 12, 2022
5f28d88
reformat section, and minor fixes
tshepang Aug 12, 2022
639671a
missing word
tshepang Aug 12, 2022
bc02fa3
repetition
tshepang Aug 12, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
missing commas
  • Loading branch information
@tshepang
tshepang committed Aug 12, 2022
commit b2e6a285b0afb03f25ac85d9252031fdcfe6c4d5
7 changes: 4 additions & 3 deletions src/diagnostics/diagnostic-items.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,10 @@ A new diagnostic item can be added with these two steps:
[*Naming Conventions*](#naming-conventions).

2. As of <!-- date-check --> February 2022, diagnostic items in code are
accessed via symbols in [`rustc_span::symbol::sym`]. To add your newly
created diagnostic item simply open the module file and add the name (In
this case `Cat`) at the correct point in the list.
accessed via symbols in [`rustc_span::symbol::sym`].
To add your newly-created diagnostic item,
simply open the module file,
and add the name (In this case `Cat`) at the correct point in the list.

Now you can create a pull request with your changes. :tada: (Note that when
using diagnostic items in other projects like Clippy, it might take some time
Expand Down