Remove ReEmpty #98559
Merged
Remove ReEmpty #98559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added the T-compiler 
rust-highfive added the S-waiting-on-review 
This comment has been minimized.
This comment has been minimized.
0xCryptoZen approved these changes Jun 27, 2022
jackh726 force-pushed the remove-reempty branch 2 times, most recently from da99507 to 531c765 Compare This comment has been minimized.
This comment has been minimized.
| ☔ The latest upstream changes (presumably #98591) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
jackh726 commented Jun 28, 2022
| ☔ The latest upstream changes (presumably #98542) made this pull request unmergeable. Please resolve the merge conflicts. |
Merged
jackh726 added S-blocked 
| Blocked on #98795 and some fiddling with the best way to the |
This comment has been minimized.
This comment has been minimized.
| ☔ The latest upstream changes (presumably #98584) made this pull request unmergeable. Please resolve the merge conflicts. |
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 8, 2022
…anup, r=compiler-errors A few cleanups Each commit is (mostly) self-explanatory. These changes have come as I try to remove `ReEmpty` (rust-lang#98559).
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 8, 2022
…anup, r=compiler-errors A few cleanups Each commit is (mostly) self-explanatory. These changes have come as I try to remove `ReEmpty` (rust-lang#98559).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 8, 2022
…anup, r=compiler-errors A few cleanups Each commit is (mostly) self-explanatory. These changes have come as I try to remove `ReEmpty` (rust-lang#98559).
jackh726 force-pushed the remove-reempty branch 2 times, most recently from cb38214 to fa7b0bb Compare jackh726 added S-waiting-on-review | I think this is good to go. The problem I was facing before went away on its own. |
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review | The job Click to see the possible cause of the failure (guessed by this bot) |
| cc @compiler-errors ICEy interactions with 🐸 types (RPITIT) |
| I'll look into it this weekend |
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 10, 2022
Equate fn outputs when inferring RPITIT hidden types When we are trying to infer the hidden types for RPITITs, we need to equate the output tys instead of just subtyping them. For example: ```rust trait Foo { fn bar() -> impl Sized {} } impl Foo for () { fn bar() -> &'static str { "" } } ``` If we just subtype the signatures `fn() -> &'static str <: fn() -> _#1t` (where `_#1t` is the variable we've used to infer `impl Sized`), we'll end up `&'static str <: _#1t`, which causes us to infer `_#1t = #'_#2r str`, where `'_#2r` is unconstrained, which gets fixed up to `ReEmpty`, and which is certainly not what we want. I can't actually think of a way to make this fail to compile, because during borrowck we've already done the method probe, and so we just look at the `impl` method signature and see the `&'static str` any time we call `<() as Foo>::bar()`. But this _does_ cause the ICE [here](rust-lang#98559 (comment)) in `@jackh726's` "Remove ReEmpty" PR (rust-lang#98559) to stop ICEing, because after that PR we were leaking unconstrained region variables into the typeck results. r? types bors added S-waiting-on-bors 
fbstj reviewed Sep 10, 2022
| (VarValue::Empty(a_ui), VarValue::Empty(b_ui)) => { | ||
| // Empty regions are ordered according to the universe | ||
| // they are associated with. | ||
| a_ui.min(b_ui) == b_ui |
There was a problem hiding this comment.
is this not a >= b ? or am I misunderstanding what min is doing?
| ☀️ Test successful - checks-actions |
This was referenced Sep 10, 2022
| Finished benchmarking commit (2287107): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
| @jackh726 seeing an ICE which bisected to this merge, stacktrace: I will try to produce a MRE |
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 6, 2022
Remove ReEmpty r? rust-lang/types
| I just tried the latest nightly (2022-10-11) after 1 month and this patch still causes an ICE. Is it something that can be solved easily or planned to be fixed? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
r? rust-lang/types