Rollup of 5 pull requests #98263
Closed
Rollup of 5 pull requests #98263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This stabilizes the `Path::try_exists()` method which returns `Result<bool, io::Error>` instead of `bool` allowing handling of errors unrelated to the file not existing. (e.g permission errors) Along with the stabilization it also: * Warns that the `exists()` method is error-prone and suggests to use the newly stabilized one. * Suggests it instead of `metadata()` to handle errors. * Mentions TOCTOU bugs to avoid false assumption that `try_exists()` is completely safe fixed version of `exists()`. * Renames the feature of still-unstable `std::fs::try_exists()` to `fs_try_exists` to avoid name conflict. The tracking issue rust-lang#83186 remains open to track `fs_try_exists`.
… path This ensures that changes to target json files will force a recompilation. And more importantly that moving the files doesn't force a recompilation.
This is useful for combinators. I didn't add `clone` since you can already use `Clone::clone` in its place; copy has no such corresponding function.
Add `core::mem::copy` to complement `core::mem::drop`. This is useful for combinators. I didn't add `clone` since you can already use `Clone::clone` in its place; copy has no such corresponding function.
…r=dtolnay Stabilize `Path::try_exists()` and improve doc This stabilizes the `Path::try_exists()` method which returns `Result<bool, io::Error>` instead of `bool` allowing handling of errors unrelated to the file not existing. (e.g permission errors) Along with the stabilization it also: * Warns that the `exists()` method is error-prone and suggests to use the newly stabilized one. * Suggests it instead of `metadata()` to handle errors. * Mentions TOCTOU bugs to avoid false assumption that `try_exists()` is completely safe fixed version of `exists()`. * Renames the feature of still-unstable `std::fs::try_exists()` to `fs_try_exists` to avoid name conflict. The tracking issue rust-lang#83186 remains open to track `fs_try_exists`.
…r=Amanieu Leak pthreax_mutex_t when it's dropped while locked. Fixes rust-lang#85434.
…agisa Make debug_triple depend on target json file content rather than file path This ensures that changes to target json files will force a recompilation. And more importantly that moving the files doesn't force a recompilation. This should fix Rust-for-Linux/linux#792 (cc `@ojeda)`
…lan-DPC Fix typos in `IntoFuture` docs
rustbot added T-compiler 
| @bors r+ p=5 rollup=never |
| 📌 Commit f75b442 has been approved by |
bors added the S-waiting-on-bors | ⌛ Testing commit f75b442 with merge c612bd3e125fe438260cdc12ecd18c40620874c4... |
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review 
| The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
core::mem::copyto complementcore::mem::drop. #95534 (Addcore::mem::copyto complementcore::mem::drop.)Path::try_exists()and improve doc #97912 (StabilizePath::try_exists()and improve doc)IntoFuturedocs #98257 (Fix typos inIntoFuturedocs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup