Fix invalid lint_node_id being put on a removed stmt #94554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added the T-compiler 
rust-highfive added the S-waiting-on-review 
| @bors r+ rollup |
| 📌 Commit 5164884 has been approved by |
bors added S-waiting-on-bors Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 3, 2022
Fix invalid lint_node_id being put on a removed stmt This pull-request remove a invalid `assign_id!` being put on an stmt node. The problem is that this node is being removed away by a cfg making it unreachable when triggering a buffered lint. The comment in the other match arm already tell to not assign a id because it could have a `#[cfg()]` so this is just respecting the comment. Fixes rust-lang#94523 r? `@petrochenkov`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 3, 2022
Fix invalid lint_node_id being put on a removed stmt This pull-request remove a invalid `assign_id!` being put on an stmt node. The problem is that this node is being removed away by a cfg making it unreachable when triggering a buffered lint. The comment in the other match arm already tell to not assign a id because it could have a `#[cfg()]` so this is just respecting the comment. Fixes rust-lang#94523 r? `````@petrochenkov`````
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 3, 2022
Fix invalid lint_node_id being put on a removed stmt This pull-request remove a invalid `assign_id!` being put on an stmt node. The problem is that this node is being removed away by a cfg making it unreachable when triggering a buffered lint. The comment in the other match arm already tell to not assign a id because it could have a `#[cfg()]` so this is just respecting the comment. Fixes rust-lang#94523 r? ``````@petrochenkov``````
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92697 (Use cgroup quotas for calculating `available_parallelism`) - rust-lang#94057 (improve comments for `simplify_type`) - rust-lang#94547 (`parse_tt` cleanups) - rust-lang#94550 (rustdoc: Add test for higher kinded functions generated by macros) - rust-lang#94551 (Doc: Fix use of quote instead of backstick in Adapter::map.) - rust-lang#94554 (Fix invalid lint_node_id being put on a removed stmt) - rust-lang#94555 (all: fix some typos) - rust-lang#94563 (Remove a unnecessary `..` pattern) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull-request remove a invalid
assign_id!being put on an stmt node.The problem is that this node is being removed away by a cfg making it unreachable when triggering a buffered lint.
The comment in the other match arm already tell to not assign a id because it could have a
#[cfg()]so this is just respecting the comment.Fixes #94523
r? @petrochenkov