Fix ICE when passing block to while-loop condition #94248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added the T-compiler 
| (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review 
compiler-errors commented Feb 22, 2022
| This also needs a test. |
petrochenkov added S-waiting-on-author 
estebank reviewed Feb 22, 2022
This comment was marked as resolved.
This comment was marked as resolved.
compiler-errors force-pushed the fix-while-loop-bad-delay branch from 9f48c1f to 33385e7 Compare 
| @rustbot ready I went ahead and kept the logic I added in this PR, but I am still open to removing the |
rustbot added S-waiting-on-review | r=me after addressing #94248 (comment) |
petrochenkov added S-waiting-on-author 
compiler-errors force-pushed the fix-while-loop-bad-delay branch from 33385e7 to 025b7c4 Compare | @rustbot ready |
rustbot added S-waiting-on-review | @bors r+ |
| 📌 Commit 025b7c4 has been approved by |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 28, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#92399 (fix typo in btree/vec doc: Self -> self) - rust-lang#92823 (Tweak diagnostics) - rust-lang#94248 (Fix ICE when passing block to while-loop condition) - rust-lang#94414 (Fix ICE when using Box<T, A> with large A) - rust-lang#94445 (4 - Make more use of `let_chains`) - rust-lang#94449 (Add long explanation for E0726) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We were incorrectly delaying a bug when we passed any block (that evaluated to
()) to a while loop. This PR makes the check a bit more sophisticated.We should only suppress the error here in cases that are equivalent to those we find in #93574 (i.e. only while loop conditions that have destructuring assignment expressions in them).
Fixes #93997
cc @estebank who added this code
I would not be opposed to removing the delay-bug altogether, and just emitting this error always. I much prefer duplicate errors over no errors.