suggest using raw strings when invalid escapes appear in literals #93999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot added the T-compiler 
rust-highfive added the S-waiting-on-review 
| @bors r+ rollup |
| 📌 Commit bf8f067d0734f8f52c9b560dd5c64fc9c15564d7 has been approved by |
bors added S-waiting-on-bors 
barzamin force-pushed the suggest-raw-strings branch from bf8f067 to eb6f34d Compare 
jackh726 reviewed Feb 14, 2022
i'd guess about 70% of "bad escape" cases occur when someone meant to use a raw string literal because they're passing it directly to Regex::new(). this emits an advisory (Applicability::MaybeIncorrect) help: suggestion to the user that they use an r"" string, on top of the normal notes about looking at the string literal documentation/spec.
barzamin force-pushed the suggest-raw-strings branch from eb6f34d to e59cda9 Compare 
| prevented lint from firing on byte strings + fixed up |
| @bors r+ rollup |
| 📌 Commit e59cda9 has been approved by |
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#93899 (Describe VecDeque with more consistent names) - rust-lang#93949 (Add basic platform support to library/{panic_}unwind for m68k) - rust-lang#93999 (suggest using raw strings when invalid escapes appear in literals) - rust-lang#94001 (llvm: migrate to new parameter-bearing uwtable attr) - rust-lang#94014 (Move transmute_undefined_repr back to nursery) Failed merges: - rust-lang#94020 (Support pretty printing of invalid constants) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
i'd guess about 70% of "bad escape" cases occur when someone meant to use a raw string literal because they're passing it directly to
Regex::new().this emits an advisory (
Applicability::MaybeIncorrect)help:suggestion to the user that they use anr""string, on top of the normal notes about looking at the string literal documentation/spec.