Skip to content

Move duplicates removal when generating results instead of when displaying them #92127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2021
Merged

Move duplicates removal when generating results instead of when displaying them #92127

merged 1 commit into from
Dec 21, 2021

Conversation

GuillaumeGomez
Copy link
Member

Currently, we store 200 results per tab and then display them. However, it was possible to have duplicates which is why we have this check. However, instead of doing it when displaying the results, it's much better instead to do it even before to simplify the display part a bit.

r? @jsha
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-js Area: Rustdoc's JS front-end labels Dec 20, 2021
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 20, 2021
@jsha
Copy link
Contributor

jsha commented Dec 20, 2021

@bors r+ rollup
@bors
Copy link
Collaborator

bors commented Dec 20, 2021

📌 Commit 879d28d has been approved by jsha
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2021
@bors
Copy link
Collaborator

bors commented Dec 20, 2021

⌛ Testing commit 879d28d with merge 289b933172b00793e5ecb8a3d832f80eaa5ad8e3...
@bors
Copy link
Collaborator

bors commented Dec 20, 2021

💔 Test failed - checks-actions
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2021
@matthiaskrgr
Copy link
Member

@bors retry
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Attempting with retry: docker build --rm -t rust-ci -f /gha/_work/rust/rust/src/ci/docker/host-aarch64/aarch64-gnu/Dockerfile /gha/_work/rust/rust/src/ci/docker Sending build context to Docker daemon 506.4kB Step 1/6 : FROM ubuntu:20.04 Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable Sending build context to Docker daemon 506.4kB Step 1/6 : FROM ubuntu:20.04 Step 1/6 : FROM ubuntu:20.04 Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable Sending build context to Docker daemon 506.4kB Step 1/6 : FROM ubuntu:20.04 Step 1/6 : FROM ubuntu:20.04 Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable Sending build context to Docker daemon 506.4kB Step 1/6 : FROM ubuntu:20.04 Step 1/6 : FROM ubuntu:20.04 Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable Sending build context to Docker daemon 506.4kB Step 1/6 : FROM ubuntu:20.04 Step 1/6 : FROM ubuntu:20.04 Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable ##[error]Process completed with exit code 1. Post job cleanup.
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 21, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2021
@bors
Auto merge of rust-lang#92152 - matthiaskrgr:rollup-nmskpw6, r=matthi…
3d57c61 
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90345 (Stabilise entry_insert) - rust-lang#91412 (Improve suggestions for importing out-of-scope traits reexported as `_`) - rust-lang#91770 (Suggest adding a `#[cfg(test)]` to to a test module) - rust-lang#91823 (Make `PTR::as_ref` and similar methods `const`.) - rust-lang#92127 (Move duplicates removal when generating results instead of when displaying them) - rust-lang#92129 (JoinHandle docs: add missing 'the') - rust-lang#92131 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
@GuillaumeGomez
Copy link
Member Author

@bors retry
@bors bors merged commit b9c3243 into rust-lang:master Dec 21, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 21, 2021
@GuillaumeGomez GuillaumeGomez deleted the search-results-duplicate-removal branch December 21, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

7 participants

@GuillaumeGomez @rust-highfive @jsha @bors @matthiaskrgr @rust-log-analyzer @rustbot