Skip to content

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Sep 24, 2021

closes #83564

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 25, 2021

📌 Commit 4c23905 has been approved by joshtriplett

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 25, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2021
…arth Rollup of 7 pull requests Successful merges: - rust-lang#88895 (rustdoc: Cleanup `clean` part 2) - rust-lang#88973 (Expose the std_detect env_override feature) - rust-lang#89010 (Add some intra doc links) - rust-lang#89198 (rustdoc: Don't show hidden trait methods) - rust-lang#89216 (Consistent big O notation) - rust-lang#89224 (Change the order of imports suggestions) - rust-lang#89256 (Fix typo in release notes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
@camelid camelid added the A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` label Sep 26, 2021
@camelid
Copy link
Member

camelid commented Sep 26, 2021

Does this change need a regression test for the diagnostic?

@bors bors merged commit 04d3f93 into rust-lang:master Sep 26, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 26, 2021
@leonardo-m
Copy link

I am not sure, but it seems this has stopped working. On this code:

fn main() { let _ = Wrapping(5_u32); }

rustc gives now (rustc 1.58.0-nightly 29b1248 2021-10-25):

error[E0425]: cannot find function, tuple struct or tuple variant `Wrapping` in this scope --> ...\test.rs:2:13 | 2 | let _ = Wrapping(5_u32); | ^^^^^^^^ not found in this scope | help: consider importing one of these items | 1 | use core::num::Wrapping; | 1 | use std::num::Wrapping; |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

6 participants