Skip to content

Add a regression test for #88649 #88691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Sep 8, 2021
Merged

Add a regression test for #88649 #88691

merged 1 commit into from Sep 8, 2021

Conversation

@ghost
Copy link

@ghost ghost commented Sep 6, 2021

I noticed that #88649 does not have a regression test, so I add one in this PR.

The test fails with this without #88678:

error[E0080]: evaluation of constant value failed --> /checkout/src/test/ui/consts/issue-88649.rs:13:52 | LL | Foo::Variant1(x) | Foo::Variant2(x) if x => {} | ^ StorageLive on a local that was already live error: aborting due to previous error For more information about this error, try `rustc --explain E0080`.
@rust-highfive
Copy link
Contributor

rust-highfive commented Sep 6, 2021

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2021
camelid
camelid reviewed Sep 6, 2021
View reviewed changes
@camelid camelid added the A-testsuite Area: The testsuite used to check the correctness of rustc label Sep 6, 2021
@Mark-Simulacrum Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 7, 2021
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Sep 7, 2021

@bors r+ rollup

Also beta-nom alongside #88678 to make sure we have a test if we're backporting the original patch.
@bors
Copy link
Collaborator

bors commented Sep 7, 2021

📌 Commit 214eef0 has been approved by Mark-Simulacrum
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2021
@jackh726 jackh726 mentioned this pull request Sep 8, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2021
@bors
Auto merge of rust-lang#88750 - jackh726:rollup-w57i9fp, r=jackh726
47ae8de 
Rollup of 9 pull requests Successful merges: - rust-lang#86263 (Rustdoc: Report Layout of enum variants) - rust-lang#88541 (Add regression test for rust-lang#74400) - rust-lang#88553 (Improve diagnostics for unary plus operators (rust-lang#88276)) - rust-lang#88594 (More symbolic doc aliases) - rust-lang#88648 (Correct “copies” to “moves” in `<Option<T> as From<T>>::from` doc, and other copyediting) - rust-lang#88691 (Add a regression test for rust-lang#88649) - rust-lang#88694 (Drop 1.56 stabilizations from 1.55 release notes) - rust-lang#88712 (Fix docs for `uX::checked_next_multiple_of`) - rust-lang#88726 (Fix typo in `const_generics` replaced with `adt_const_params` note) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit f69ccb1 into rust-lang:master Sep 8, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 8, 2021
@camelid camelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 8, 2021
@ghost ghost deleted the 88649 branch September 10, 2021 14:15
@pnkfelix pnkfelix mentioned this pull request Sep 16, 2021
Merged
@pnkfelix
Copy link
Contributor

pnkfelix commented Sep 16, 2021

beta-backport approved, coupled to PR #88678. (I.e. their backport should be treated as one unit.)
@apiraino
Copy link
Contributor

apiraino commented Sep 16, 2021

Discussion of the compiler team on Zulip

@rustbot label +beta-accepted
@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 16, 2021
@cuviper cuviper mentioned this pull request Sep 16, 2021
Merged
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 16, 2021
@cuviper cuviper modified the milestones: 1.57.0, 1.56.0 Sep 16, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2021
@bors
Auto merge of rust-lang#88946 - cuviper:beta-next, r=Mark-Simulacrum
deef866 
[beta] backports - rustdoc: Fix ICE with `doc(hidden)` on tuple variant fields rust-lang#88639 - Fix 2021 `dyn` suggestion that used code as label rust-lang#88657 - Workaround blink/chromium grid layout limitation of 1000 rows rust-lang#88776 - Change scope of temporaries in match guards rust-lang#88678 - Add a regression test for rust-lang#88649 rust-lang#88691 - Revert anon union parsing rust-lang#88775 - Disable validate_maintainers. rust-lang#88977 Also drop stage0 rustfmt, because that's only supposed to be used on master. r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

8 participants

@rust-highfive @Mark-Simulacrum @bors @pnkfelix @apiraino @camelid @cuviper @rustbot