Fix codeblocks overflow #87056
Merged
Fix codeblocks overflow #87056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GuillaumeGomez added T-rustdoc 
| Some changes occurred in HTML/CSS/JS. |
rust-highfive added the S-waiting-on-review 
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez force-pushed the fix-codeblocks-overflow branch 2 times, most recently from 0c8c8d7 to fc8600d Compare 
| ☔ The latest upstream changes (presumably #87095) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez force-pushed the fix-codeblocks-overflow branch from fc8600d to 09270ed Compare 
| r? @notriddle |
notriddle approved these changes Jul 13, 2021
| @bors: r=notriddle |
| 📌 Commit 09270ed has been approved by |
bors added S-waiting-on-bors GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 13, 2021
…low, r=notriddle Fix codeblocks overflow Fixes rust-lang#87043. Instead of completely relying on `pulldown-cmark` (and its potential changes), I decided to move the generation of codeblocks HTML directly in rustdoc so we can unify the DOM and the CSS classes. r? `@Nemo157`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 13, 2021
…low, r=notriddle Fix codeblocks overflow Fixes rust-lang#87043. Instead of completely relying on `pulldown-cmark` (and its potential changes), I decided to move the generation of codeblocks HTML directly in rustdoc so we can unify the DOM and the CSS classes. r? ``@Nemo157``
| ⌛ Testing commit 09270ed with merge b6139eccc1932ed0cacffd743f35795a8d672207... |
This comment has been minimized.
This comment has been minimized.
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review notriddle reviewed Jul 13, 2021
GuillaumeGomez force-pushed the fix-codeblocks-overflow branch from 09270ed to 7593bfe Compare | @bors: r=notriddle |
| 📌 Commit 7593bfe has been approved by |
bors added S-waiting-on-bors bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2021
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#87027 (expand: Support helper attributes for built-in derive macros) - rust-lang#87056 (Fix codeblocks overflow) - rust-lang#87117 (Shrink the CrateStore dynamic interface.) - rust-lang#87120 (rustdoc: Remove unnecessary `extern crate` aliases) - rust-lang#87125 (Fix Ayu theme `<code>` color) - rust-lang#87130 (Update browser-ui-test package version) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #87043.
Instead of completely relying on
pulldown-cmark(and its potential changes), I decided to move the generation of codeblocks HTML directly in rustdoc so we can unify the DOM and the CSS classes.r? @Nemo157