Revert "implement TrustedRandomAccess for Take iterator adapter" #85975
+1 −22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 37a5b51.
| r? @scottmcm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review | @rustbot label T-libs-impl |
rustbot added the T-libs 
| 📌 Commit dbc43ec has been approved by |
bors added S-waiting-on-bors | ☀️ Test successful - checks-actions |
wesleywiser added beta-nominated 
Mark-Simulacrum removed the beta-nominated bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2021
…imulacrum [stable] 1.53.0 release This includes a backport of: * Revert "implement TrustedRandomAccess for Take iterator adapter" rust-lang#85975 And includes patches to: * Update release notes to reflect rust-lang#85541 * Require RUSTC_FORCE_INCREMENTAL to truly enable incremental, fixing rust-lang#86004 * This reverts alignment-related commits to address issue rust-lang#85713 on beta. r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This reverts commit 37a5b51 (#83990).
The original change unintentionally caused side-effects from certain iterator chains combining
take,zipandnext_back()to be omitted which is observable by user code and thus likely a breaking changeTechnically one could declare it not a breaking change since
Zip's API contract is silent about about its backwards iteration behavior but on the other hand there is nothing in the stable Iterator API that could justify the currently observable behavior. And either way, this impact wasn't noticed or discussed in the original PR.Fixes #85969