Rollup of 8 pull requests #84525
Merged
Rollup of 8 pull requests #84525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is a quick-fix for an ICE in `tabs_in_doc_comments`. The problem was that we we're indexing into possibly multi-byte characters, such as '位'. More specifically `get_chunks_of_tabs` was returning indices into multi-byte characters. Those were passed on to a `Span` creation that then caused the ICE. This fix makes sure that we don't return indices that point inside a multi-byte character. *However*, we are still iterating over unicode codepoints, not grapheme clusters. So a seemingly single character like y̆ , which actually consists of two codepoints, will probably still cause incorrect spans in the output.
Only lint when `into_iter` is an implementation of `IntoIterator` Minor cleanups
Fix `macro_use_import` ICE fixes: rust-lang#7015 changelog: Fix `macro_use_import` ICE
…ffen Invalid null usage v2 This is continuation of rust-lang#6192 after inactivity. I plan to move paths into the compiler as diagnostic items after this is merged. fixes rust-lang#1703 changelog: none
This still applies the lint, and also adds a structured suggestion to rename it.
Use `register_renamed` instead of `register_removed` for uplifted lints This still applies the lint, and also adds a structured suggestion to rename it. changelog: Use `register_renamed` instead of `register_removed` for lints uplifted to rustc
…fn, r=flip1995 Remove `debug_assert` from `panic_in_result_fn` I couldn't find any documentation on `debug_assert` that should be remove. In my humble opinion, I would also like to argue that `todo` and `unreachable` shouldn't trigger this lint? Related: rust-lang/rust-clippy#6082 r? `@flip1995` changelog: Change `panic_in_result_fn` to ignore `debug_assert` and co macros
…arth Fix false-positive `debug_assert` in `panic` This fixes a false-positive in `clippy::panic` when `debug_assert` is used with a message. Fixes rust-lang/rust-clippy#7062. changelog: Fix false-positive in `panic` when `debug_assert` is used with a message
…0, r=giraffate Fix FP in `single_component_path_imports` lint Fix FP in `single_component_path_imports` lint when the import is reused with `self`, like in `use self::module`. Fixes rust-lang#5210 changelog: none
Deprecate `filter_map` Since rust-lang#6591, `filter_map` does not even lint `filter().map()`. The cases that are still linted make no sense IMO. So this just removes/deprecates it. changelog: Deprecate `filter_map` lint Closes rust-lang#3424 Fixes rust-lang#7050
…ishearth Add a note on the issue rust-lang#5953 Hello, I thought it would be better to have a note and warning about this issue considering it introduced an UB in the past even with the "Search on Github" feature. --- changelog: Add a note on the issue rust-lang#5953 to the known problems section.
The JSON renderer no longer gets called on modules.
…ode, r=pnkfelix Implement a lint that highlights all moves larger than a configured limit Tracking issue: rust-lang#83518 [MCP 420](rust-lang/compiler-team#420) still ~blazing~ in progress r? ```@pnkfelix``` The main open issue I see with this minimal impl of the feature is that the lint is immediately "stable" (so it can be named on stable), even if it is never executed on stable. I don't think we have the concept of unstable lint names or hiding lint names without an active feature gate, so that would be a bigger change.
…ef, r=m-ou-se stabilize `core::array::{from_ref,from_mut}` in `1.53.0` I didn't get any response in rust-lang#77101 (comment), so I figured out I can try opening stabilization pr. --- This PR stabilizes following functions: ```rust // core::array pub fn from_ref<T>(s: &T) -> &[T; 1]; pub fn from_mut<T>(s: &mut T) -> &mut [T; 1]; ``` Functions are similar to already stabilized `core::slice::{`[`from_ref`](https://doc.rust-lang.org/std/slice/fn.from_ref.html),[`from_mut`](https://doc.rust-lang.org/std/slice/fn.from_mut.html)`}` and were unstable without any problems/questions for a while now. --- resolves rust-lang#77101 ``@rustbot`` modify labels: +T-libs Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}` Remove the field `_dont_send_or_sync_me: PhantomData<*mut ()>` in favor of an explicit implementation of `!Send` and `!Sync`. Update Clippy r? ```@Manishearth``` Biweekly Clippy update.
rustdoc: Turn `JsonRenderer::mod_item_in` into `unreachable!()` The JSON renderer no longer gets called on modules (since rust-lang#83055). r? ``@aDotInTheVoid``
rustdoc: Remove unnecessary `is_crate` field from doctree::Module and clean::Module It can be calculated on-demand even without a TyCtxt. This also changed `json::conversions::from_item_kind` to take a whole item, which avoids having to add more and more parameters. Helps with rust-lang#76382. r? ```@camelid```
rustdoc: Get rid of `clean::TypeKind` It does exactly the same thing as ItemType.
…g, r=jsha Clean up DOM strings Follow-up of rust-lang#84320. r? ``@jsha``
| @bors r+ p=8 rollup=never |
| 📌 Commit 5716bab has been approved by |
bors added the S-waiting-on-bors | ☀️ Test successful - checks-actions |
This was referenced Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
core::array::{from_ref,from_mut}in1.53.0#84105 (stabilizecore::array::{from_ref,from_mut}in1.53.0)!Sendand!Syncforsys::{Args, Env}#84179 (Explicitly implement!Sendand!Syncforsys::{Args, Env})JsonRenderer::mod_item_inintounreachable!()#84459 (rustdoc: TurnJsonRenderer::mod_item_inintounreachable!())is_cratefield from doctree::Module and clean::Module #84460 (rustdoc: Remove unnecessaryis_cratefield from doctree::Module and clean::Module)clean::TypeKind#84464 (rustdoc: Get rid ofclean::TypeKind)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup