Add primary marker on codegen unit and generate main wrapper on primary codegen. #84507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
crlf0710 added the S-experimental 
This comment has been minimized.
This comment has been minimized.
crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from 37490ab to c5406cd Compare This comment has been minimized.
This comment has been minimized.
crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from c5406cd to 7167212 Compare This comment has been minimized.
This comment has been minimized.
crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from 4fc092b to 977c2a7 Compare This comment has been minimized.
This comment has been minimized.
crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from 44150ec to 6b9e621 Compare This comment has been minimized.
This comment has been minimized.
crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from 6b9e621 to dea2655 Compare This comment has been minimized.
This comment has been minimized.
crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from dea2655 to 6c7abc8 Compare This comment has been minimized.
This comment has been minimized.
crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from 6c7abc8 to 268479e Compare This comment has been minimized.
This comment has been minimized.
| ☔ The latest upstream changes (presumably #84310) made this pull request unmergeable. Please resolve the merge conflicts. |
bors added the S-waiting-on-author crlf0710 removed the S-waiting-on-author crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch 3 times, most recently from 9182f04 to 231b44c Compare crlf0710 added S-waiting-on-author crlf0710 changed the title 
This comment has been minimized.
This comment has been minimized.
crlf0710 removed the S-waiting-on-author crlf0710 added the S-waiting-on-review crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from 231b44c to d84848b Compare 5 tasks
| Introducing a flag looks like a pretty okay approach, but I'm not a fan of how or where the flag is set in the first place. It seems to me that setting the |
crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from d84848b to f6e3335 Compare | @nagisa Thanks for the review! I addressed the comments above. |
nagisa reviewed May 8, 2021
crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from f6e3335 to f84b26d Compare This comment has been minimized.
This comment has been minimized.
… non-local cases.
crlf0710 force-pushed the codegen_nonlocal_main_wrapper branch from f84b26d to 89a6705 Compare | @nagisa Review comments addressed~ |
| @bors r+ thanks! |
| 📌 Commit 89a6705 has been approved by |
bors added S-waiting-on-bors Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 9, 2021
…per, r=nagisa Add primary marker on codegen unit and generate main wrapper on primary codegen. This is the codegen part of changes extracted from rust-lang#84062. This add a marker called `primary` on each codegen units, where exactly one codegen unit will be `primary = true` at a time. This specific codegen unit will take charge of generating `main` wrapper when `main` is imported from a foreign crate after the implementation of RFC 1260. cc rust-lang#28937 I'm not sure who should i ask for review for codegen changes, so feel free to reassign. r? `@nagisa`
| ☀️ Test successful - checks-actions |
| This has landed. @bjorn3 |
| Thanks. I will update cg_clif tomorrow when the next nightly is released. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is the codegen part of changes extracted from #84062.
This add a marker called
primaryon each codegen units, where exactly one codegen unit will beprimary = trueat a time. This specific codegen unit will take charge of generatingmainwrapper whenmainis imported from a foreign crate after the implementation of RFC 1260.cc #28937
I'm not sure who should i ask for review for codegen changes, so feel free to reassign.
r? @nagisa