Rollup of 10 pull requests #81271
Merged
Rollup of 10 pull requests #81271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was already implied because Any: 'static, but this makes it explicit.
…ther something is a union
Co-authored-by: Miguel Ojeda <ojeda@users.noreply.github.com>
Previously, it would usually get computed by LLVM, but this enforces it.
Otherwise rust-analyzer doesn't understand vec![].
When encountering a name `a` that isn't resolved, but a label `'a` is found in the current ribs, only suggest `'a` if this name is the value expression of a `break` statement. Solve FIXME.
Point at loop head on invalid `break expr`. Suggest removing `expr` or using label if available.
When encountering the following typo: ```rust a: loop { break 'a; } ``` provide an appropriate suggestion. Deny rustc::internal lints for rustdoc and clippy - Fix rustc::internal lints for rustdoc - Deny internal lints only for rustdoc and clippy (previously the lints were ignored for clippy because -Zunstable-options didn't get passed)
Expand docs on Iterator::intersperse Unstable feature in rust-lang#79524. This expands on the docs to bring them more in line with how other methods of `Iterator` are demonstrated.
Stabilize std::panic::panic_any. This stabilizes `std::panic::panic_any`.
Don't prefix 0x for each segments in `dbg!(Ipv6)` Fixes rust-lang#81182
Make 'docs' nullable in rustdoc-json output Matches the backing better, and makes it so there's a difference between 'empty docs' and 'no docs'.
…n514 Remove doctree::StructType Also removes it from the Union type, as unions can only ever be 'Plain'. Adds a new StructType to JSON, 'union', as the easiest way to encode the type of a union there. This leaves only one item in doctree, `Module`. r? `@jyn514`
Document why not use concat! in dbg! macro Original title: Reduce code generated by `dbg!` macro The expanded code before/after: <https://rust.godbolt.org/z/hE3j95>. --- We cannot use `concat!` since `file!` could contains `{` or the expression is a block (`{ .. }`). Using it will generated malformed format strings. So let's document this reason why we don't use `concat!` macro at all.
Gracefully handle loop labels missing leading `'` in different positions Fix rust-lang#81192. * Account for labels when suggesting `loop` instead of `while true` * Suggest `'a` when given `a` only when appropriate * Add loop head span to hir * Tweak error for invalid `break expr` * Add more misspelled label tests * Avoid emitting redundant "unused label" lint * Parse loop labels missing a leading `'` Each commit can be reviewed in isolation.
…li-obk Turn alloc's force_expr macro into a regular macro_rules. This turns `alloc`'s `force_expr` macro into a regular `macro_rules`. Otherwise rust-analyzer doesn't understand `vec![]`. See rust-lang/rust-analyzer#7349 and rust-lang#81080 (comment) Edit: See rust-lang#81241 (comment) for a discussion of alternatives.
Enforce statically that `MIN_NON_ZERO_CAP` is calculated at compile time Previously, it would usually get computed by LLVM, but this enforces it. This removes the need for the comment saying "LLVM is smart enough". I don't expect this to make a performance difference, but I do think it makes the performance properties easier to reason about.
| @bors r+ p=10 rollup=never |
| 📌 Commit 9c2a577 has been approved by |
bors added the S-waiting-on-bors | ☀️ Test successful - checks-actions |
This was referenced Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
dbg!(Ipv6)#81202 (Don't prefix 0x for each segments indbg!(Ipv6))'in different positions #81236 (Gracefully handle loop labels missing leading'in different positions)MIN_NON_ZERO_CAPis calculated at compile time #81242 (Enforce statically thatMIN_NON_ZERO_CAPis calculated at compile time)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup