Update Clippy #80623
Merged
Update Clippy #80623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* last minor improvements
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
…t is missing on a nightly Clippy should always be available on nightly because we are gating on it in rustcs CI.
readme: remove paragraph about installing clippy manually on ci, if it is missing on a nightly Clippy should always be available on nightly because we are gating on it in rustcs CI. changelog: remove outdated readme paragraph
…, r=llogiq Don't trigger large_enum_variant in external macros Closes rust-lang#1776 (the potential JSON output issue is not something we can fix in Clippy and I can't reproduce it anymore) changelog: Don't trigger [`large_enum_variant`] in external macros
This most likely no longer works since we are pinning clippy on a specific nightly now. "cargo run" would try to compile clippy with whatever version the project we want to check demands. Also building clippy yourself to run it on a project is not really needed anymore since clippy is shipped with official rust releases. Fixes rust-lang#6489
remove clone in manual_async_fn lint changelog: none
Added from_over_into lint Closes rust-lang#6456 Added a lint that searches for implementations of `Into<..>` and suggests to implement `From<..>` instead, as it comes with a default implementation of `Into`. Category: style. changelog: added `from_over_into` lint
readme: remove paragraph about executing clippy via "cargo run .." This most likely no longer works since we are pinning clippy on a specific nightly now. "cargo run" would try to compile clippy with whatever version the project we want to check demands. Also building clippy yourself to run it on a project is not really needed anymore since clippy is shipped with official rust releases. Fixes rust-lang#6489 changelog: none
The default value for a field type does not necessarily match the default value for that field in the struct Default.
There is already an assertion that consecutive lines assign to a struct field.
…=ebroto Revert "Pass Clippy args also trough RUSTFLAGS" Reverts rust-lang/rust-clippy#6441 r? `@ebroto` changelog: Revert "Pass Clippy args also trough RUSTFLAGS"
ci: test cargo clippy --fix -Zunstable-options Make sure we catch cases like rust-lang/rust-clippy#6487 in CI in the future. --- *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: none
…killercup Website issue tracker link and better search performance This PR implements some improvements to the website: 1. Added a "Search on Github" link to the "Known problems" section (Closes rust-lang#5386)  <details> <summary>Another mock up I created with the GitHub logo</summary>  </details> 2. Only starting the search after three letters and improving the search performance in general. (Followup rust-lang#6477) ### Testing These changes can be tested locally by: 1. Clone this branch 2. Download the current lint index from the [gh-pages branch](https://github.com/rust-lang/rust-clippy/blob/gh-pages/master/lints.json) 3. Put it next to the `util/gh-pages/index.html` and open the html file. Make sure that it can load the lint data. (Browsers can be a bit iffy when opening a local html page and loading data) ### Sources for search performance: 1. [A stackoverflow about angular filter performance](https://stackoverflow.com/questions/26876514/optimize-angular-filter-performance) * I selected a search debounce of 50ms that's fast enough to catch fast deletion and typing but responsive enough to not bother the user 2. [A stackoverflow about string comparison speeds](https://stackoverflow.com/questions/5296268/fastest-way-to-check-a-string-contain-another-substring-in-javascript) 3. [JS benchmarks for string search performance (`indexOf` seams to be the best)](https://jsben.ch/9cwLJ) Note: The performance is still a bit poor when going from a specific lint to no search filter. I suspect that angular is recreating all lint items when the filter is cleared causing a major lag spike. The filter functions is at least optimized for little to no search. --- changelog: Added a "Search on GitHub" link to the website
fix ci on master branch; run the --fix test in the correct directory Turned out the --fix test was run in the wrong directory. *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: none
- Adds optional default values to const generic parameters in the AST and HIR - Parses these optional default values - Adds a `const_generics_defaults` feature gate
Clippy treated Rust 2021 as Rust 2015, because 2018 was checked with `==` instead of `>=`. This fixes that, such that 2018-specific things are also enabled for 2021.
Initial support for Rust 2021. Clippy treated Rust 2021 as Rust 2015, because 2018 was checked with `==` instead of `>=`. This fixes that, such that 2018-specific things are also enabled for 2021. changelog: Added support for Rust 2021.
Rustup r? `@ghost` changelog: none
rust-highfive added the S-waiting-on-review 
Collaborator
| The job Click to see the possible cause of the failure (guessed by this bot) |
Member
Mmh, simply calling edit: feel free to temporarily disable the test. I'll need to figure out how x.py provides its rustc to the tools |
Member Author
@matthiaskrgr It should work with |
Member
Does that also work with our compiletest-based setup in the clippy repo? |
Member Author
| I just synced back 5dd64b3 locally and it passed the Clippy test suite. So yes, this works now for both repos, rust-clippy and rust. |
Member
| @bors r+ |
Collaborator
| 📌 Commit 5dd64b3 has been approved by |
bors added S-waiting-on-bors Collaborator
Member
| @bors p=2 |
Collaborator
| ☀️ Test successful - checks-actions |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Biweekly Clippy update.
This includes a Cargo.lock update for the recent Clippy version bump.
r? @Manishearth