Rollup of 11 pull requests #77589
Closed
Rollup of 11 pull requests #77589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replaces simple bool `match`es of the form match $expr { $pattern => true _ => false } and their inverse with invocations of the matches! macro. 
…ant in the language. (Note that the fact this test existed is a slight sign that we may need a crater run on this bugfix...)
That is, this changes `#[forbid(foo)] #[allow(foo)]` from allowing foo to forbidding foo.
…odrAus Add a note about the panic behavior of math operations on time objects Fixes #71226.
Reduce boilerplate with the matches! macro Replaces simple bool `match`es of the form match $expr { $pattern => true _ => false } and their inverse with invocations of the matches! macro. Limited to rustc_middle for now to get my feet wet. Add missing examples for MaybeUninit r? @Dylan-DPC
Rename bootstrap/defaults/{config.toml.PROFILE => config.PROFILE.toml} This allows these files to have okay syntax highlighting in editors, and helps avoid nagging from editors which want to suggest that I install a plugin for `*.library` files to view the `config.toml.library` or whatever. It's a very minor change. r?@jyn514 Fix LitKind's byte buffer to use refcounted slice While working on adding a new lint for clippy (see rust-lang/rust-clippy#6044) for avoiding shared ownership of "mutable buffer" types (such as using `Rc<Vec<T>>` instead of `Rc<[T]>`), I noticed a type exported from rustc_ast and used by clippy gets caught by the lint. This PR fixes the exported type. This PR includes the actual change to clippy too, but I will open a PR directly against clippy for that part (although it will currently fail to build there).
inliner: use caller param_env We used the callee param env instead of the caller param env by accident in #77430, this PR fixes that and caches it in the `Inliner` struct. fixes #77564 r? @ecstatic-morse
Use matches! for core::char methods
Fix span for unicode escape suggestion. If a unicode escape is missing the curly braces, the suggested fix is to add the curly braces, but the span for the fix was incorrect. It was not covering the `\u`, but the suggested text includes the `\u`, causing the resulting fix to be `"\u\u{1234}"`. This changes it so that the span includes the `\u`. An alternate fix would be to remove `\u` from the suggested fix, but I think the error message reads better if the entire escape is included. 
| 📌 Commit 7af4959 has been approved by |
bors added the S-waiting-on-bors | ⌛ Testing commit 7af4959 with merge 7249e4285462f522a6a0667112e87a422cebb9f2... |
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review | Hmm, the only thing I can see is that the coverage tests are failing on AArch64 only, with diffs like - | <generics::Firework<i32> as core::ops::drop::Drop>::drop: + | <generics::Firework<i32> as core[a7a74cee373f048]::ops::drop::Drop>::drop:That seems weird, they're already failing in #77080, so they shouldn't cause the whole pipeline to fail (the builder is called "fallible") |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost