Deprecate clippy lint

src/tools/clippy/clippy_lints/src/deprecated_lints.rs

@@ -163,3 +163,12 @@ declare_deprecated_lint! {
  pub REGEX_MACRO,
  "the regex! macro has been removed from the regex crate in 2018"
 }
+
+declare_deprecated_lint! {
+ /// **What it does:** Nothing. This lint has been deprecated.
+ ///
+ /// **Deprecation reason:** This lint has been uplifted to rustc and is now called
+ /// `drop_bounds`.
+ pub DROP_BOUNDS,
+ "this lint has been uplifted to rustc and is now called `drop_bounds`"
+}

src/tools/clippy/clippy_lints/src/lib.rs

@@ -179,7 +179,6 @@ mod derive;
 mod doc;
 mod double_comparison;
 mod double_parens;
-mod drop_bounds;
 mod drop_forget_ref;
 mod duration_subsec;
 mod else_if_without_else;
@@ -478,6 +477,10 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
  "clippy::regex_macro",
  "the regex! macro has been removed from the regex crate in 2018",
  );
+ store.register_removed(
+ "clippy::drop_bounds",
+ "this lint has been uplifted to rustc and is now called `drop_bounds`",
+ );
  // end deprecated lints, do not remove this comment, it’s used in `update_lints`
 
  // begin register lints, do not remove this comment, it’s used in `update_lints`
@@ -532,7 +535,6 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
  &doc::NEEDLESS_DOCTEST_MAIN,
  &double_comparison::DOUBLE_COMPARISONS,
  &double_parens::DOUBLE_PARENS,
- &drop_bounds::DROP_BOUNDS,
  &drop_forget_ref::DROP_COPY,
  &drop_forget_ref::DROP_REF,
  &drop_forget_ref::FORGET_COPY,
@@ -959,7 +961,6 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
  store.register_late_pass(|| box strings::StringLitAsBytes);
  store.register_late_pass(|| box derive::Derive);
  store.register_late_pass(|| box types::CharLitAsU8);
- store.register_late_pass(|| box drop_bounds::DropBounds);
  store.register_late_pass(|| box get_last_with_len::GetLastWithLen);
  store.register_late_pass(|| box drop_forget_ref::DropForgetRef);
  store.register_late_pass(|| box empty_enum::EmptyEnum);
@@ -1282,7 +1283,6 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
  LintId::of(&doc::NEEDLESS_DOCTEST_MAIN),
  LintId::of(&double_comparison::DOUBLE_COMPARISONS),
  LintId::of(&double_parens::DOUBLE_PARENS),
- LintId::of(&drop_bounds::DROP_BOUNDS),
  LintId::of(&drop_forget_ref::DROP_COPY),
  LintId::of(&drop_forget_ref::DROP_REF),
  LintId::of(&drop_forget_ref::FORGET_COPY),
@@ -1714,7 +1714,6 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
  LintId::of(&copies::IF_SAME_THEN_ELSE),
  LintId::of(&derive::DERIVE_HASH_XOR_EQ),
  LintId::of(&derive::DERIVE_ORD_XOR_PARTIAL_ORD),
- LintId::of(&drop_bounds::DROP_BOUNDS),
  LintId::of(&drop_forget_ref::DROP_COPY),
  LintId::of(&drop_forget_ref::DROP_REF),
  LintId::of(&drop_forget_ref::FORGET_COPY),

src/tools/clippy/clippy_lints/src/utils/paths.rs

@@ -31,7 +31,6 @@ pub const DISPLAY_FMT_METHOD: [&str; 4] = ["core", "fmt", "Display", "fmt"];
 pub const DISPLAY_TRAIT: [&str; 3] = ["core", "fmt", "Display"];
 pub const DOUBLE_ENDED_ITERATOR: [&str; 4] = ["core", "iter", "traits", "DoubleEndedIterator"];
 pub const DROP: [&str; 3] = ["core", "mem", "drop"];
-pub const DROP_TRAIT: [&str; 4] = ["core", "ops", "drop", "Drop"];
 pub const DURATION: [&str; 3] = ["core", "time", "Duration"];
 pub const EARLY_CONTEXT: [&str; 4] = ["rustc", "lint", "context", "EarlyContext"];
 pub const EXIT: [&str; 3] = ["std", "process", "exit"];

src/tools/clippy/src/lintlist/mod.rs

@@ -423,13 +423,6 @@ pub static ref ALL_LINTS: Vec<Lint> = vec![
  deprecation: None,
  module: "double_parens",
  },
- Lint {
- name: "drop_bounds",
- group: "correctness",
- desc: "bounds of the form `T: Drop` are useless",
- deprecation: None,
- module: "drop_bounds",
- },
  Lint {
  name: "drop_copy",
  group: "correctness",

src/tools/clippy/tests/ui/deprecated.rs

@@ -8,5 +8,6 @@
 #[warn(clippy::into_iter_on_array)]
 #[warn(clippy::unused_label)]
 #[warn(clippy::regex_macro)]
+#[warn(clippy::drop_bounds)]
 
 fn main() {}

src/tools/clippy/tests/ui/deprecated.stderr

@@ -60,11 +60,17 @@ error: lint `clippy::regex_macro` has been removed: `the regex! macro has been r
 LL | #[warn(clippy::regex_macro)]
  | ^^^^^^^^^^^^^^^^^^^
 
+error: lint `clippy::drop_bounds` has been removed: `this lint has been uplifted to rustc and is now called `drop_bounds``
+ --> $DIR/deprecated.rs:11:8
+ |
+LL | #[warn(clippy::drop_bounds)]
+ | ^^^^^^^^^^^^^^^^^^^
+
 error: lint `clippy::str_to_string` has been removed: `using `str::to_string` is common even today and specialization will likely happen soon`
  --> $DIR/deprecated.rs:1:8
  |
 LL | #[warn(clippy::str_to_string)]
  | ^^^^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 11 previous errors
+error: aborting due to 12 previous errors