Remove the old copy propagation pass #77373
Conversation
| (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review 
| You'll probably know better than me who a good reviewer here is - I don't have sufficient context I think, so I'll let you reassign. |
| r? @oli-obk |
There was a problem hiding this comment.
this should probably be renamed
There was a problem hiding this comment.
Renamed to "final"
There was a problem hiding this comment.
Do we have tests for all of these situations for the dest-prop opt?
There was a problem hiding this comment.
I ported this test over, the results look correct
| lgtm. r=me with nits resolved |
| @bors try @rust-timer queue |
| Awaiting bors try build completion |
| ⌛ Trying commit 8aa1239de1c8daab86d44fdd93b5ed1f91369136 with merge f60f56e913fc86e229f05dff68d2853916dbf706... |
| ☀️ Try build successful - checks-actions, checks-azure |
| Queued f60f56e913fc86e229f05dff68d2853916dbf706 with parent 3bbc443, future comparison URL. |
| Finished benchmarking try commit (f60f56e913fc86e229f05dff68d2853916dbf706): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
| @bors rollup- |
| (the pass doesn't run by default, so there's no perf impact) |
camelid added A-mir-opt 
| @jonas-schievink Could you resolve the merge conflicts? |
camelid added S-waiting-on-review | @bors r+ |
| 📌 Commit dc31777 has been approved by |
bors removed the S-waiting-on-review bors added the S-waiting-on-bors | ☀️ Test successful - checks-actions, checks-azure |
9 participants
This pass was added a long time ago, and has not really seen much improvement since (apart from some great work in #76569 that unfortunately ran into preexisting soundness issues). It is slow and unsound, and we now have a destination propagation pass that performs a related optimization and could be extended.
Closes #36673
Closes #73717
Closes #76740