Revert "De-share ast::Ty" #7644
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Revert the removal of the
@fromTyas I think it caused the memory regression seen here in #7615. The graph posted on that PR is from before this change.Since
Tyis a recursive type, I think that the change from@to~meant that a copy that would previously stop at the@continued. It seems to me that during syntax folding, the data was being kept around somehow, causing the bloat.This reverts commit 47eca21.